[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New margin handling - final version (updated)

From: Neil Puttock
Subject: Re: [PATCH] New margin handling - final version (updated)
Date: Fri, 11 Sep 2009 20:53:49 +0100

2009/9/11 Michael Käppler <address@hidden>:
> Hi all,
> I've just removed some code from page.scm that becomes obsolete through the
> patch.

Just a few comments:

Can you rebase your changes in so they don't
revert the changes made since your original patch?

The regression test would probably benefit from being split into
several separate tests, particularly the final check-consistency
setting, which can then have #(ly:set-option 'warning-as-error #f)
added to it in anticipation of the mythical time when we can switch
this option on for regression testing. :)

+  line_width = line_width - robust_scm2double (c_variable
("line-width-cropping"), 0);

line_width -= robust_scm2double (c_variable ("line-width-cropping"), 0);

> I would be really happy if somebody could test this for regressions. The
> problem is that for me it takes more than 12 hours to run a "make doc" and
> for this time I can't do anything other.
> (Just to give you an impression about my system's slowness)


I'm happy to run the tests again.  I'll report back once it's completed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]