Re: [PATCH] New margin handling - final version (updated)

[Neil Puttock]

2009/9/11 Michael Käppler <address@hidden>:
> Hi all,
> I've just removed some code from page.scm that becomes obsolete through the
> patch.

Just a few comments:

Can you rebase your changes in paper-defaults-init.ly so they don't
revert the changes made since your original patch?

The regression test would probably benefit from being split into
several separate tests, particularly the final check-consistency
setting, which can then have #(ly:set-option 'warning-as-error #f)
added to it in anticipation of the mythical time when we can switch
this option on for regression testing. :)

+  line_width = line_width - robust_scm2double (c_variable
("line-width-cropping"), 0);

line_width -= robust_scm2double (c_variable ("line-width-cropping"), 0);

> I would be really happy if somebody could test this for regressions. The
> problem is that for me it takes more than 12 hours to run a "make doc" and
> for this time I can't do anything other.
> (Just to give you an impression about my system's slowness)

Ouch.

I'm happy to run the tests again.  I'll report back once it's completed.

Regards,
Neil