[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New margin handling - final version (updated)

From: John Mandereau
Subject: Re: [PATCH] New margin handling - final version (updated)
Date: Sat, 26 Sep 2009 01:18:29 +0200

Le vendredi 25 septembre 2009 à 23:59 +0100, Neil Puttock a écrit :
> LGTM, though I'd appreciate it if somebody else could give the patch a
> final look (especially the lilypond-book changes, since I'm not that
> familiar with it).

Sure, see below.

> --- a/scripts/
> +++ b/scripts/
> +       # FIXME: This is really ugly. Every setting should be there only once,
> +       # instead of having several line-width = foo / line-width = blah
> +       # constructs. This would affect also QUOTE / LILYQUOTE, however.

This comment reveals a larger issue than the code it comments, so I
suggest to move it away from and rewrite it in Git
commit message and/or an issue on the tracker.


Attachment: signature.asc
Description: Ceci est une partie de message numériquement signée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]