lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tracker 836: Add facility to change output file-name for a \book blo


From: pnorcks
Subject: Re: Tracker 836: Add facility to change output file-name for a \book block
Date: Wed, 04 Nov 2009 01:06:22 +0000


http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
I would recommend indenting like so:

  (for-each
    (lambda (symbol)
      (let ((..

http://codereview.appspot.com/143055/diff/19/1020#newcode142
Line 142: (if (not book-filename)
The if block should be indented two more spaces here.

http://codereview.appspot.com/143055/diff/19/1020#newcode143
Line 143: (ly:parser-output-name parser)
These two lines should begin in the same column as (not ...)

http://codereview.appspot.com/143055/diff/19/1020#newcode149
Line 149: (let ((book-output-suffix (ly:parser-lookup parser
'book-output-suffix)))
indent the if block

http://codereview.appspot.com/143055/diff/19/1020#newcode151
Line 151: (ly:parser-lookup parser 'output-suffix)
align these with (not ...)

http://codereview.appspot.com/143055




reply via email to

[Prev in Thread] Current Thread [Next in Thread]