lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary


From: David Kastrup
Subject: Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups
Date: Tue, 24 Nov 2009 17:31:42 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

David Kastrup <address@hidden> writes:

> Nicolas Sceaux <address@hidden> writes:
>
>> I'd be insterested to see an implementation of a single
>> `define-markup-command' for builtin and user defined markups, where
>> user defined commands do not pollute the (lily) module, and still are
>> available across file includes.
>>
>> If you can come up with one, fine, I'm not opposed to #:property or
>> #:category keywords. But if that's not possible, then please stop with
>> this macro unification debate. IMHO it's just waisting time, for this
>> is not a problem that you're trying to solve, but at most a little
>> inconvenience.
>
>> PS: *please*, call things by there name, it's "builtin", not
>> "internal".
>
> Wouldn't it be worth it alone to do this change because of not having to
> get annoyed time and again by me confusing the two?
>
> I'll see whether I can cook up a suitable patch.

Done.  The current state of <URL:http://codereview.appspot.com/160048>
(Patchset 4) removes *-builtin-* completely and appears to pass all
tests.

-- 
David Kastrup





reply via email to

[Prev in Thread] Current Thread [Next in Thread]