[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix issue 1011
From: |
Carl Sorensen |
Subject: |
Re: [PATCH] Fix issue 1011 |
Date: |
Sat, 13 Feb 2010 11:23:25 -0700 |
On 2/13/10 10:45 AM, "Christian Hitz" <address@hidden> wrote:
>
> In order to verify the fix I have added a new regression test suite
> lilypondbook_html. It tests the lilypond-book operation when processing HTML
> files. Most of the patch is related to this regression test.
>
> http://codereview.appspot.com/206092/show
Looks good to me, but I'm always nervous about patches on the makefile
system.
>
> Note: Rietveld insists on squashing my Git commits. I'll provide a set of
> patches when the changes are ready to be pushed.
Yes, that's how Rietveld works. If you want to keep patches separate, you
can do so by putting each patch on a separate branch.
HTH,
Carl