Re: Font_metric code cleanup breaks fetaText positioning

[Patrick McCarty]

On 2010-03-22, Patrick McCarty wrote:
> On 2010-03-22, Han-Wen Nienhuys wrote:
> > On Mon, Mar 22, 2010 at 11:02 PM, Patrick McCarty
> > <address@hidden> wrote:
> > >
> > > Previous to your changes, IIRC, text_stencil() was never called.
> > 
> > Are you sure?
> > 
> > SCM
> > Text_interface::interpret_string (SCM layout_smob,
> >                                   SCM props,
> >                                   SCM markup)
> > 
> > -which powers all markup text- is basically a call to
> > Font_metric::text_stencil().
> 
> True.  I see why this is so confusing.  I'll try my best to explain.

[...]

> In what situations would a "non-tight" bbox be useful, since we don't
> appear to be using it right now?

Update:

It looks like the logical extents are used for leading, and it
definitely has an effect on vertical alignment of text, since the
Y-extents for stencils are different with the logical extents than
with the ink extents.

Though, I think this has been broken for a long time...

I'll have a look tomorrow to see if I can come up with a fix.


Thanks,
Patrick