Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes

[Neil Puttock]

On 30 March 2010 16:00, Richard Gay <address@hidden> wrote:

> It worked for me with \grace and \appoggiatura notes but lilypond
> showed warnings nevertheless (as noted in the patched
> `Documentation/notation/vocal.itely'). I tried to fix these spurious
> warnings but failed. The patch applies to current git
> (d2f1fdc35a9764f749a99a54db7bb988f455c3ed).

The warnings aren't spurious, since the lyrics aren't attached to the
grace notes (the incorrect alignment gives this away): they end up
aligned to the nearest paper column.

If you have a look at get_current_note_head () in lyric-engraver.cc,
you'll see it returns NULL if the current head is a grace note.  I
suggest reworking it slightly to added a boolean arg include_graces so
both the Lyric_engraver and Extender_engraver can read
includeGraceNotes and pass the value.

Don't forget to add includeGraceNotes to the engraver documentation
(it should go in the `read' section in the ADD_TRANSLATOR () macro at
the bottom of both engravers).

Cheers,
Neil