[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: accessors for note-column's dot-column, accidentals
From: |
Nicolas Sceaux |
Subject: |
Re: PATCH: accessors for note-column's dot-column, accidentals |
Date: |
Mon, 5 Apr 2010 10:55:25 +0200 |
Le 4 avr. 2010 à 20:20, Joe Neeman a écrit :
> On Sun, 2010-04-04 at 11:46 +0200, Nicolas Sceaux wrote:
>> +LY_DEFINE (ly_note_column__accidentals,
>> "ly:note-column::accidentals",
>> + 1, 0, 0, (SCM note_column),
>> + "Return the first accidentals found in @var{note_column},
>> or #f.")
>
> Why not use DECLARE_SCHEME_CALLBACK and DEFINE_SCHEME_CALLBACK instead
> of LY_DEFINE?
Right! Actually, it is the functions names that I should change, in
order to be consistent with LilyPond's style:
ly:note-column-accidentals
in the same fashion as other accessors:
ly:grob-parent
ly:paper-book-systems
ly:parser-lexer
ly:pitch-notename
etc.
Also the accessors should return SCM_EOL iso SCM_BOOL_F.
Thanks!
Nicolas