[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes
From: |
Neil Puttock |
Subject: |
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes |
Date: |
Fri, 16 Apr 2010 00:15:53 +0100 |
On 13 April 2010 00:28, Richard Gay <address@hidden> wrote:
> Thanks again for your help. I quickly added a @knownissues to the docs
> of the feature and added your code from below as an example for a
> solution (if this is overkill, it's easily removed again).
No, that looks fine.
> I slightly modified the regression test for the lyric extender towards
> your example.
Can you change the docstring for this test so mentions extenders (just
to make it clear from the text what's being tested)?
> Even if I have to admit that I don't really understand it, this issue
> seems to be fixed by changing the patch as follows:
Good work! It doesn't seem to break anything as far as I can tell (at
the very least, there are no regressions showing up).
Just a few more minor details to sort out, then it should be ready for pushing:
address@hidden,ragged-right,quote]
+<<
+ \relative c' {
...
+>>
For the examples using \addlyrics, you can remove the << >> block (the
parser interprets the music + lyrics as simultaneous automatically).
+ c2 \grace { c16([ d e f] } g2) f1
newline before f1
+ (include_grace_notes && end_mom->grace_part_ > now.grace_part_))
indent
+ && dynamic_cast<Item *>(g)
+ && Note_head::has_interface(g))
space before (g)
Cheers,
Neil
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/01
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/03
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/10
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/12
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/12
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Graham Percival, 2010/04/13
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes,
Neil Puttock <=
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/16
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/18
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/18
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/18