[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Cri
From: |
Karl Hammar |
Subject: |
Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues) |
Date: |
Mon, 17 May 2010 10:11:17 +0200 (CEST) |
-
This is a multipart MIME message.
Karl Hammar:
> Carl Sorensen:
> ...
> > I've posted a patch on Rietveld. Can you do the
> > regression test?
> > http://codereview.appspot.com/1195044
>
> After a make test-redo I get:
>
> . the "mandatory" output-distance.
> . a diff of tree.gittext, showing Carls patch
> . 314 below threshold
> . 2062 unchanged
>
> From this I assume Carls patch does not affect any present regression
> test.
Sorry to bring this up again, but this conclusion is still unproven,
since the test was done with "test-redo". As I have found out in the
thread for the issue 915, "test-redo" does not test the things we
wanted to test.
***
$ git-status
# On branch master
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
#
# issue1195044_1_2.diff
# issue1195044_1_3.diff
# issue931041_1.diff
nothing added to commit but untracked files present (use "git add" to track)
$ git-log | head -1
commit 22d889f4d27469864c31db81445e9de49774ae23
$ cat issue1195044_1_[23].diff | patch -p1
patching file scm/define-grobs.scm
patching file scm/output-lib.scm
$ make check > log 2>&1
...
And I get a distance of 18.406667 in the attached output. The
difference seems to be because the c and the b are horizontally closer
to each other.
Regards,
/Karl Hammar
tie-semi-single.compare.jpeg
Description: tie-semi-single.compare.jpeg
tie-semi-single.png
Description: tie-semi-single.png
- Re: Critical issues, (continued)
- Re: Critical issues, Karl Hammar, 2010/05/14
- Re: Critical issues, Carl Sorensen, 2010/05/14
- Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues), Karl Hammar, 2010/05/14
- Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues), Carl Sorensen, 2010/05/14
- Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues), Karl Hammar, 2010/05/15
- Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues), Carl Sorensen, 2010/05/15
- Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues),
Karl Hammar <=
- Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues), Karl Hammar, 2010/05/17
Re: Critical issues, Karl Hammar, 2010/05/13
Re: Critical issues, Graham Percival, 2010/05/13