[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "a *= 1 / b" → "a /= b"
|
From: |
Reinhold Kainhofer |
|
Subject: |
Re: "a *= 1 / b" → "a /= b" |
|
Date: |
Sun, 13 Jun 2010 19:22:57 +0200 |
|
User-agent: |
KMail/1.13.3 (Linux/2.6.32-22-generic; KDE/4.4.4; i686; ; ) |
Am Sonntag, 13. Juni 2010, um 18:48:28 schrieb Lôrinc:
> I have just started browsing the lily source and would like to send my
> first cosmetics patch. All I did was changed a few "*= 1 /" to"/=" and
> wrote the needed overloaded /= operators in interval and offset.
Looks good to me.
I wouldn't add the empty line in flower/offset.hh, though.
> Please let me know if I did anything wrong, as I would like to send some
> more patches in the future.
Yes, of course. If you are using git, you might want to look at git-cl (please
search in the mailing list archives) and upload patches to
codereview.appspot.com
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org