Re: PATCH: issue 1116 (fill-line regression 2.13.11 to 2.13.12+)

[Alexander Kobel]

On 2010-06-14 20:24, Neil Puttock wrote:
> On 14 June 2010 15:34, Alexander Kobel<address@hidden>  wrote:
>
> > Besides, I tried to tackle the issue I mentioned here:
> > <http://www.mail-archive.com/address@hidden/msg51242.html>, which is
> > that nested fill-lines used to shift their contents by some amount to the
> > right.
>
> Heh, I was just about to post a fix for that myself
> (http://code.google.com/p/lilypond/issues/detail?id=382), using a
> slightly different approach: checking whether the text-width equals or
> exceeds line-width.

I thought about that, too, when I first tried to do this several months 
ago.  Not sure why it didn't work out; probably it was just a < vs. <= 
issue.
On the other hand, I don't quite get why word-space = 1 is necessary. 
If there's no space left, the user has trouble anyway, and I don't see 
why an arbitrary minimum space should help.  And this should be the 
reason for the shift, IIUC.  Seems like an ugly hack to me, but probably 
there's some reason?

Another question: What does "mol" stand for in the markup definitions, 
e.g. in general-align in define-markup-commands.scm?

> > For some reason, I don't seem to be able to build the regtests; so all this
> > should be taken with care, I did not really check if it breaks anything.
>
> It compiles fine without any breakages.

That's how far I could go.  I just can't get the regression tests, so I 
can't compare if it breaks desired output in other examples than mine.

> > And once again, please clean up the indentation.  The "real" sources just
> > look like a complete mess in my Emacs configuration.  I did not try to
> > understand this, but rather to guess my tabs and spaces to fit...
>
> Doesn't C-M-\ indent a region for you automatically?

It does, but it also reindents the existing code in a completely 
different manner than what's currently there.

> One thing your patch doesn't cover is Reinhold's problem with compound
> time signature formatting (see
> http://code.google.com/p/lilypond/issues/detail?id=732);

Okay; didn't check this.  Probably one can see it in some regression 
test, then...

> I wonder
> whether we should just add his suggestion for translating the stencil
> returned by \center-column onto its left edge (which would simplify
> your \fill-line fix.)

If we do, we should probably "normalize" all stacked stencils (read: 
right-column, too) in the same manner.  Which would make sense to me, 
since it's a consistent behaviour, but I suspect this to be incompatible 
with the current design.  And one might require to write \right-align 
\right-column to get the (current?) extent ((- width) . 0), which looks 
clumsy from the typical user's POV.


Cheers,
Alexander