lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for issue #1116 (one stencil in fill-line) (issue1689041)


From: joeneeman
Subject: Patch for issue #1116 (one stencil in fill-line) (issue1689041)
Date: Wed, 30 Jun 2010 18:34:35 +0000

Are you still waiting for someone to review this? If so, here are a
couple minor things:


http://codereview.appspot.com/1689041/diff/2001/3001
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/1689041/diff/2001/3001#newcode848
scm/define-markup-commands.scm:848: X RIGHT fill-space line-stencils)))
These two set!s could be written more concisely as
(set! line-stencils
  (stack-stencils-padding-list
   X RIGHT fill-space empty-stencil)))

http://codereview.appspot.com/1689041/diff/2001/3001#newcode850
scm/define-markup-commands.scm:850: (if (> word-count 1)
I know there aren't many comments in the code, but that doesn't mean you
can't add one...

http://codereview.appspot.com/1689041/show



reply via email to

[Prev in Thread] Current Thread [Next in Thread]