|
From: | David Kastrup |
Subject: | Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041) |
Date: | Sun, 01 Aug 2010 22:09:13 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
address@hidden writes: > LGTM. > > Are you going to do the docs in a separate patch? "make test" did not turn up problems with unpatched docs (the docs are really just few lines in one file: there is no serious doc to speak of). But I don't really understand why. I can make the doc change a separate commit or not, whatever people prefer. Given its minimal size (and the disturbing detail that it does not change the version number of the snippet, anyway), I'd think that a single commit may be appropriate. -- David Kastrup
[Prev in Thread] | Current Thread | [Next in Thread] |