Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

[ian]

http://www.codereview.appspot.com/1160044/diff/51001/52005
File scm/lily.scm (right):

http://www.codereview.appspot.com/1160044/diff/51001/52005#newcode215
scm/lily.scm:215: (apply fancy-format (cons dest . rest))))
On 2010/08/09 18:35:54, Patrick McCarty wrote:
> `cons' only works with two concrete arguments, like

>    (cons dest rest)

Done.

http://www.codereview.appspot.com/1160044/diff/51001/52005#newcode219
scm/lily.scm:219: (catch 'format
On 2010/08/09 19:08:58, Neil Puttock wrote:
> On 2010/08/09 18:35:54, Patrick McCarty wrote:
> > Is this change supposed to be part of the patchset?

> I don't think it should be. :)

> > Also, I don't understand the logic here.  Is 'format ever thrown?
If so,
> which
> > procedure does this?

> There's no exception for 'format, so it's never thrown.  I think this
would only
> work if it were changed to

> (catch #t

Done.

http://www.codereview.appspot.com/1160044/diff/51001/52005#newcode223
scm/lily.scm:223: (lambda (key dest . rest) (simple-format-handler dest
. rest))))
On 2010/08/09 19:08:58, Neil Puttock wrote:
> Should be

> (lambda (key . args) (apply simple-format-handler (cons dest rest)))

Done.

http://www.codereview.appspot.com/1160044/diff/51001/52005#newcode258
scm/lily.scm:258: (define-public  (guile-v2 )
On 2010/08/09 19:08:58, Neil Puttock wrote:
> (define-public (guile-v2)

Done.

http://www.codereview.appspot.com/1160044/show