Re: Style: don't break compiling freetype-errors.cc (issue2144047)

[percival . music . ca]

On 2010/09/11 07:02:55, perpeduumimmobile wrote:
> Wouldn't it be easier to just say
> - if a line belongs to a preprocessor statement
>    (i.e. it either starts with "#" or
>          each of the lines before end with "\", and the first line
>          of those starts with "#")
> then leave it alone (dont merge another line on this, don't take some
characters
> out to the next)?  This would solve all those preprocessor related
issues, and
> seems easier.

How could that be done?  I'm not sufficiently familiar with fixcc.py to
spot this immediately.  The regexes sometimes span multiple lines, so
I'm sure that it doesn't just go through and modify each line
individually.

> Typically only the three groups #include, #define / #undef and #if /
#ifdef /
> #endif make out nearly all of the preprocessor directives (unless
there are a
> lot of special optimizations like OpenMP use or
compiler/platform-dependent
> performance tweaks).  Do we really want to care about the others at
the risk of
> running into compiling issues?

I honestly don't think that we're going to keep fixcc.py, so I don't
think it's worth future-proofing it to that extent.  Don't get me wrong
-- if we were going to keep it, it would definitely be worth looking
into that change.  But in these circumstances, I think it would be more
trouble than it's worth.

Cheers,
- Graham

http://codereview.appspot.com/2144047/