[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tablature: proper support for tie/slur- and tie/glissando-constellat
From: |
n . puttock |
Subject: |
Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042) |
Date: |
Thu, 16 Sep 2010 21:14:19 +0000 |
Hi Marc,
In hide-tab-note-head, you end up setting properties on bounds which
aren't noteheads (i.e., for broken bounds, the ties are bound by a
NonMusicalPaperColumn); till now you've got away with it, since the
properties being set were from the grob-interface (unlike 'details).
Try running `make check' to see what I mean. ;)
Cheers,
Neil
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly
File input/regression/tablature-tie-slur-glissando.ly (right):
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly#newcode1
input/regression/tablature-tie-slur-glissando.ly:1: \version "2.13.35"
"2.13.34"
http://codereview.appspot.com/2191042/diff/1/input/regression/tablature-tie-slur-glissando.ly#newcode3
input/regression/tablature-tie-slur-glissando.ly:3: \header{ texidoc =
"If a slur or a glissando follows a tie, the
formatting
http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm#newcode1979
scm/define-grobs.scm:1979: (tied-to . #f)))
On 2010/09/16 10:32:52, Carl wrote:
tied-from might be a better name than tied-to, since it's the property
of the
left-hand note that we're adjusting, rather than the property of the
right hand
note.
How about `tied-left'? It gives an indication of the direction of the
tie away from this notehead.
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm
File scm/tablature.scm (right):
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode179
scm/tablature.scm:179: (define (hide-tab-note-head grob)
This is a bit of a misnomer, since it indirectly makes some heads
visible later. It would be better if you could avoid hiding such notes
rather than hiding them, then making them visible.
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode181
scm/tablature.scm:181: (ly:grob-set-property! grob 'whiteout #f)
can remove this
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode182
scm/tablature.scm:182: (ly:grob-set-nested-property! grob '(details
tied-to) #t))
This doesn't belong in 'details since it's set beyond the user's
control: it only makes sense as an internal property, so should be
defined separately
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode186
scm/tablature.scm:186: (ly:grob-set-property! grob 'whiteout #t)
can remove this
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode275
scm/tablature.scm:275: (control-points (ly:grob-property grob
'control-points)))
remove
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode277
scm/tablature.scm:277: (if tied-to
(and tied-to
(show-tab-note-head left-tab-note-head)
http://codereview.appspot.com/2191042/diff/1/scm/tablature.scm#newcode282
scm/tablature.scm:282: (ly:grob-set-nested-property! grob
'(bound-details left padding) 0.75)))
this won't happen for tied notes after a break unless you explicitly set
'tied-to outside `hide-tab-note-head'
http://codereview.appspot.com/2191042/