lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reorganize language files and add a new \language command. (issue269


From: v . villenave
Subject: Re: Reorganize language files and add a new \language command. (issue2699041)
Date: Wed, 27 Oct 2010 00:48:09 +0000

Greetings everybody,

new patch set. Please have a look!

\version statements: I have put 2.13.38 in the regtest, but 2.14.0 in
the .ly init files. Putting a minor version number in these files just
didn't feel right.  And 2.14 is near, isn't it? (Color me optimistic.
:-)

The only change that I didn't make was:

On 2010/10/25 04:36:31, Patrick McCarty wrote:

http://codereview.appspot.com/2699041/diff/9001/ly/language-init.ly#newcode25
IMO, the code starts to look cluttered seeing all of these copyright
statements
spread throughout the file.
I would put them all in the file header.

Well, these aren't just copyright statements. These are the pitch-maps
that were previously given as block-comments in foobar.ly language
files. I merely added one-line copyright statements to give proper
attribution (although I have now also restored full GNU headers in
deprecated .ly files).  TBH, I am not sure either that these commented
chunks are that useful; however, there's little harm in keeping them for
now.

Anyway. Now I hope that we're getting somewhere :)

Cheers.

http://codereview.appspot.com/2699041/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]