lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)


From: Carl . D . Sorensen
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Wed, 03 Nov 2010 23:14:48 +0000

On 2010/11/03 20:46:27, Neil Puttock wrote:
Hi Carl,

What do you think about folding this code into the
Tab_note_heads_engraver?  We
could store the created TabNoteHead grobs and add an acknowledger for
Tie, then
set 'tie-follow in stop_translation_timestep ().


I think I'd probably go a bit farther.

What if we acknowledged ties, slurs, and glissandos (glissandi?) in the
Tab_note_head_engraver and set the desired properties there.

And then we eliminated all of the notehead handling from the slur
callback, the tie callback, and the glissando callback.

That way the notehead callback could take care of the notehead, and we
wouldn't need to mix things at all.

What do you think?

Carl


http://codereview.appspot.com/2723043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]