lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Delay part-combine texts until a real note is encountered


From: Reinhold Kainhofer
Subject: [PATCH] Delay part-combine texts until a real note is encountered
Date: Thu, 25 Nov 2010 00:41:52 +0100
User-agent: KMail/1.13.5 (Linux/2.6.35-22-generic; KDE/4.5.3; i686; ; )

In the part-combiner, if one voice has a full-bar rest and the other voice has 
some rests and then sets in with a solo during the measure, the part-combined 
result is terribly broken (by design), so one has to override the part-
combiner to start the Solo at the beginning of the measure. In real scores, 
however, the part-combine text should always appear at the first real note of 
the solo, so the following patch adds a context property 
partCombineTextsOnNote (set in the Score context by default, but Staff will 
also work) to force this behavior and never print the part-combine text on 
rests, but rather wait for the next real note. Simple (reg)test case is 
included.

Here's the Patch:
http://codereview.appspot.com/3285042

Okay to commit?

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]