[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Pseudo-patch] Add support for HairpinText indications. (issue350904
Re: [Pseudo-patch] Add support for HairpinText indications. (issue3509041)
Sun, 12 Dec 2010 00:07:02 +0000
On 8 December 2010 08:09, <address@hidden> wrote:
> [I should probably subscribe the codereview mail address to Frogs- and
> move the discussion there.]
Sounds sensible to me.
> Thanks Neil! I've now tried to make a proper Spanner, which raises more
> questions of course (namely, how to properly start and finish it): right
> now there's no segfault anymore, but a "must have Item for spanner
> bound" error.
Did you notice which grob's missing the bound, though? It's not what
you'd expect (i.e., the HairpinText grob :)
(hint: the code you've added for HairpinText prevents a Hairpin from
> Interesting. I hadn't understood that the second argument was the grob
> cause, but that makes sense. (I guess that's why many grobs are created
> with make_item ("FooBar", SCM_EOL)?
Not all grobs are triggered by events or other grobs, so there'll
always be some with empty causes.
> Done. I also considered the possibility of using a Scheme procedure as a
> translator, but it seemed somehow uncanonical.
Actually, I think you'd find it easier to create HairpinText in a
separate engraver (at least until you're satisfied it's working
properly); this you could prototype in scheme (since you're unlikely
to need any C++ specific code).