Re: Fix 1456 (issue3693042)

[Carl . D . Sorensen]

Thanks for the excellent feedback.  I've fixed everything now.

A revised patch set is available.




http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (left):

http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely#oldcode1059
Documentation/notation/rhythms.itely:1059: \relative c' {
On 2010/12/17 22:37:36, Neil Puttock wrote:
> \new Staff

Done.

http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely#oldcode1106
Documentation/notation/rhythms.itely:1106: \relative c' {
On 2010/12/17 22:37:36, Neil Puttock wrote:
> doesn't need \new Staff, but might add for consistency with preceding
example


I've added an explanation about when contexts need to be explicitly
instantiated.  Thanks for helping to learn this.

http://codereview.appspot.com/3693042/diff/1/input/regression/multiple-time-sig-settings.ly
File input/regression/multiple-time-sig-settings.ly (left):

http://codereview.appspot.com/3693042/diff/1/input/regression/multiple-time-sig-settings.ly#oldcode11
input/regression/multiple-time-sig-settings.ly:11: \relative c' {
On 2010/12/17 22:37:36, Neil Puttock wrote:
> needs \new Staff

Done.

http://codereview.appspot.com/3693042/diff/1/input/regression/skiptypesetting-multimeasurerest.ly
File input/regression/skiptypesetting-multimeasurerest.ly (right):

http://codereview.appspot.com/3693042/diff/1/input/regression/skiptypesetting-multimeasurerest.ly#newcode10
input/regression/skiptypesetting-multimeasurerest.ly:10: \version
"2.13.43"
On 2010/12/17 22:37:36, Neil Puttock wrote:
> On 2010/12/17 13:53:37, Graham Percival wrote:
> > I guess this should be .44 ?  or .36 ?  I mean, nothing's changed in
this
> > file...?

> It should be removed.  There's already a version string at the top of
the file.

Done.

http://codereview.appspot.com/3693042/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/3693042/diff/1/ly/music-functions-init.ly#newcode747
ly/music-functions-init.ly:747: (revert-time-signature-setting
time-signature))
On 2010/12/17 22:37:36, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/3693042/diff/1/scm/time-signature-settings.scm
File scm/time-signature-settings.scm (left):

http://codereview.appspot.com/3693042/diff/1/scm/time-signature-settings.scm#oldcode294
scm/time-signature-settings.scm:294: (if (and (pair? rest) (symbol? (car
rest)))
On 2010/12/17 22:37:36, Neil Puttock wrote:
> remove (+ `rest' arg)

Yeah, I was trying to decide if I should leave it in.  I made the wrong
decision,
thinking "we might use it sometime...."

Done

http://codereview.appspot.com/3693042/diff/1/scm/time-signature-settings.scm#oldcode304
scm/time-signature-settings.scm:304: time-signature . rest)
On 2010/12/17 22:37:36, Neil Puttock wrote:
> remove `rest' arg

Done.

http://codereview.appspot.com/3693042/diff/1/scm/time-signature-settings.scm#oldcode312
scm/time-signature-settings.scm:312: (if (and (pair? rest) (symbol? (car
rest)))
On 2010/12/17 22:37:36, Neil Puttock wrote:
> remove

Done.

http://codereview.appspot.com/3693042/