[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] make post-event music functions direction-aware (issue374304
From: |
n . puttock |
Subject: |
Re: [Patch] make post-event music functions direction-aware (issue3743043) |
Date: |
Tue, 21 Dec 2010 22:21:38 +0000 |
On 2010/12/21 14:19:56, Valentin Villenave wrote:
something like that? (see new patch set)
Almost there, but you're still setting 'direction unconditionally
instead of checking first, i.e.,
$$ = run_music_function (PARSER, $2);
if ($1)
{
unsmob $$ and set direction
}
Cheers,
Neil
http://codereview.appspot.com/3743043/
- Re: [Patch] make post-event music functions direction-aware (issue3743043), (continued)
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), Carl . D . Sorensen, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), n . puttock, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), n . puttock, 2010/12/20
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), Carl . D . Sorensen, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043),
n . puttock <=
- Re: [Patch] make post-event music functions direction-aware (issue3743043), n . puttock, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), n . puttock, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), v . villenave, 2010/12/21
- Re: [Patch] make post-event music functions direction-aware (issue3743043), n . puttock, 2010/12/21