[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

fixing compiler warnings

From: Graham Percival
Subject: fixing compiler warnings
Date: Sun, 26 Dec 2010 19:25:18 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

Hi Werner,

Are you certain that this is a good change:

diff --git a/lily/ b/lily/
index b2ff830..28bf90a 100644 (file)
--- a/lily/
+++ b/lily/
@@ -79,7 +79,7 @@ Font_metric::count () const

-Font_metric::get_indexed_char_dimensions (size_t k) const
+Font_metric::get_indexed_char_dimensions (size_t) const
   return Box (Interval (0, 0), Interval (0, 0));

I mean, the function is not returning the char dimensions of a
particular index k.  Anybody calling that function might get a
nasty surprise when they discover that the parameter does nothing.
In this case, I would have thought that the compiler warning might
be useful, in the hopes that somebody would investigate it in
detail and figure out what was supposed to be happening.

I have similar concerns about the argument changes to
Pango_font::text_stencil  and  Figured_bass_engraver::listen_rest.

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]