[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fixing compiler warnings

From: Han-Wen Nienhuys
Subject: Re: fixing compiler warnings
Date: Sun, 26 Dec 2010 17:40:32 -0200

On Sun, Dec 26, 2010 at 5:25 PM, Graham Percival
<address@hidden> wrote:
> Are you certain that this is a good change:
> I mean, the function is not returning the char dimensions of a
> particular index k.  Anybody calling that function might get a
> nasty surprise when they discover that the parameter does nothing.
> In this case, I would have thought that the compiler warning might
> be useful, in the hopes that somebody would investigate it in
> detail and figure out what was supposed to be happening.
> I have similar concerns about the argument changes to
> Pango_font::text_stencil  and  Figured_bass_engraver::listen_rest.

I am 99% sure these are default implementations of virtual methods,
ie. useful subclasses do something useful in these  methods.

Han-Wen Nienhuys - address@hidden -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]