[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Re: Clef support for cue notes (issue2726043)

From: Reinhold Kainhofer
Subject: [PATCH] Re: Clef support for cue notes (issue2726043)
Date: Tue, 28 Dec 2010 22:10:07 +0100
User-agent: KMail/1.13.5 (Linux/2.6.35-23-generic; KDE/4.5.4; i686; ; )

I have now uploaded a final patch for cue notes with custom clef, which I think 
is in a state so that it can be included in lilypond master:

Any further objectsions/suggestions? Or can I push to master?

I have included almost all comments so far, except for:

-) code duplication with the Clef_engraver, which is not easily solved, since 
we need to call also member functions of the engraver and access lots of 
different properties. The only way to share code would be to use a function 
with ~7 arguments, one of which is a pointer to the engraver, two would be 
refernces to the engraver's clef_ and octavate_ members, which the function 
would set. I don't think this is really good coding practice, so I didn't 
change that. 
If did resolve the OctavateEight code duplication in Cue_clef_engraver, 

-) code duplication in scm/parser-clef.scm, which also needs to set several 
properties with different names for standard clefs and for cue clefs.

Reinhold Kainhofer, address@hidden,
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 *, DVR: 0005886
 * LilyPond, Music typesetting,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]