[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add dots to tocItemMarkup (issue4182056)
From: |
Carl . D . Sorensen |
Subject: |
Re: Add dots to tocItemMarkup (issue4182056) |
Date: |
Wed, 16 Feb 2011 14:36:46 +0000 |
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994
scm/define-markup-commands.scm:994: (define (nest-patterns pattern
pattern-width distance count patterns)
On 2011/02/16 14:26:45, Bertrand Bordage wrote:
Ok. So, the input arguments will be "count", "pattern" and "distance"
(in this
order) ? Or just "count" and "pattern" ?
As a markup function, they should be count, pattern, distance. The
order doesn't really matter. My preference would be pattern, count,
distance.
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode1021
scm/define-markup-commands.scm:1021: }
On 2011/02/16 14:26:45, Bertrand Bordage wrote:
Maybe a smaller example ? Shall we see more possibilities ? With a
\override
#'(line-width . 50) for example.
I think what's here is sufficient. But I wouldn't be opposed to a
change.
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode1032
scm/define-markup-commands.scm:1032: (x-offset (+ (* (- (- middle-width
(* patterns-number period)) pattern-width) (/ (1+ dir) 2)) (abs (car
pattern-x-extent)))))
On 2011/02/16 14:26:45, Bertrand Bordage wrote:
(my Lord ;o) )
^^^^^^ -- Yikes!
http://codereview.appspot.com/4182056/
- Add dots to tocItemMarkup (issue4182056), Carl . D . Sorensen, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056),
Carl . D . Sorensen <=
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), Carl . D . Sorensen, 2011/02/16
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/18
- Re: Add dots to tocItemMarkup (issue4182056), percival . music . ca, 2011/02/22
- Re: Add dots to tocItemMarkup (issue4182056), n . puttock, 2011/02/23
- Re: Add dots to tocItemMarkup (issue4182056), bordage . bertrand, 2011/02/23
- Re: Add dots to tocItemMarkup (issue4182056), percival . music . ca, 2011/02/24
- Re: Add dots to tocItemMarkup (issue4182056), n . puttock, 2011/02/24