Coredump and orphan avoidance code.

[Han-Wen Nienhuys]

Hi Boris,

I was looking at why

  \markuplines{}

is dumping core, and came across code committed in

commit 4878fcdb04b335041f1440c8d31b0b4b80ecaea9
Author: Boris Shingarov <address@hidden>

  Prob *ps;
  SCM list;
  for (list = texts ; scm_is_pair (list) ; list = scm_cdr (list))
            ...
   if (list == texts)
           {


complaints:

1. this code leaves ps and list uninitialized. Always initialize *all*
local variables.

2. the if never fires, unless tests==SCM_EOL in the first place

3. Given that the if never fires, do we have a regression test that
covers this code,  and are you sure this actually does something
useful?

Can you please fix this, both the esthetics and the functionality; it
is a release blocking problem.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen