[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)
From: |
n . puttock |
Subject: |
Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042) |
Date: |
Mon, 28 Feb 2011 23:04:20 +0000 |
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc
File lily/balloon.cc (right):
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc#newcode77
lily/balloon.cc:77: Grob *commonx = bounds[LEFT]->common_refpoint
(bounds[RIGHT], X_AXIS);
You might as well say
Grob *commonx = me->get_bound (LEFT);
since bounds[LEFT] is guaranteed to be the same as bounds[RIGHT]
http://codereview.appspot.com/4213042/diff/44001/lily/system.cc
File lily/system.cc (right):
http://codereview.appspot.com/4213042/diff/44001/lily/system.cc#newcode301
lily/system.cc:301: system->footnotes_ = get_footnotes_in_range (st,
end);
While this ensures we're only considering footnotes in this system, it
doesn't know whether a particular footnote is set on a grob which might
later disappear due to break-visibility settings.
Here's an example:
\relative c' {
\footnoteGrob #'Clef #'(0 . -1) "clef" "1. Clef"
c1
}
\layout {
\context {
\Staff
\consists "Footnote_engraver"
}
}
-> produces three footnotes for the visible clef and its suicided
middle- and end-of-line versions
http://codereview.appspot.com/4213042/