[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Potential fix for issue 1504. (issue4237057)
From: |
address@hidden |
Subject: |
Re: Potential fix for issue 1504. (issue4237057) |
Date: |
Sat, 12 Mar 2011 19:05:23 +0100 |
On Mar 12, 2011, at 2:49 PM, address@hidden wrote:
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc
> File lily/spanner.cc (right):
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc#newcode405
> lily/spanner.cc:405: Spanner::broken_spanner_index (Spanner const *sp)
> On 2011/03/12 10:18:06, MikeSol wrote:
>> On 2011/03/09 23:03:44, hanwenn wrote:
>> > why not make it a real member funtcion?
>
>> Actually - sorry, I spoke too soon. I see that there's a function
>> get_break_index. Could these two functions be merged? Is there a
> reason that
>> the two functions exist separately? If not, I'll merge them together.
>
> good point. Can you replace broken_spanner_index by get_break_index
> everywhere? should be separate commit to go in before this one. If it
> passes the regtest cleanly, does not need to be reviewed.
>
Passes the regtests and pushed.
- Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/09
- Re: Potential fix for issue 1504. (issue4237057), mtsolo, 2011/03/10
- Re: Potential fix for issue 1504. (issue4237057), mtsolo, 2011/03/10
- Re: Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/11
- Re: Potential fix for issue 1504. (issue4237057), mtsolo, 2011/03/12
- Re: Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/12
- Re: Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/13
Re: Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/15
Re: Potential fix for issue 1504. (issue4237057), hanwenn, 2011/03/15