[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds beam collision avoidance to auto beaming (issue4290069)
|
From: |
address@hidden |
|
Subject: |
Re: Adds beam collision avoidance to auto beaming (issue4290069) |
|
Date: |
Wed, 30 Mar 2011 12:11:53 -0400 |
On Mar 30, 2011, at 12:30 AM, address@hidden wrote:
> lgtm
>
>
> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc
> File lily/beam-collision-engraver.cc (right):
>
> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode64
> lily/beam-collision-engraver.cc:64: for (vsize j = start;
> covered_grobs_[j]->spanned_rank_interval ()[LEFT] <=
> beams_[i]->spanned_rank_interval ()[RIGHT]; j++)
> you migth want to store beam[i]->spanned_rank_interval() in a local
> variable to improve readability.
Done and pushed.
e4be20302c832985b7faac6fc0daf1f45f382391
Cheers,
MS
- Re: Adds beam collision avoidance to auto beaming (issue4290069), (continued)
Re: Adds beam collision avoidance to auto beaming (issue4290069), hanwenn, 2011/03/30
- Re: Adds beam collision avoidance to auto beaming (issue4290069),
address@hidden <=