lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Patch] Including mandolin fretboard diagrams


From: James Lowe
Subject: RE: [Patch] Including mandolin fretboard diagrams
Date: Thu, 7 Apr 2011 17:41:52 +0000

Hello

)-----Original Message-----
)From: address@hidden
)[mailto:address@hidden On
)Behalf Of Marc Hohl
)Sent: 07 April 2011 11:07
)To: Lily-Devel List; Carl D. Sorensen
)Subject: [Patch] Including mandolin fretboard diagrams
)
)Hello all,
)
)according to
)
)http://lists.gnu.org/archive/html/lilypond-user/2011-03/msg00260.html
)
)I added mandolin fretboards and hopefully included the stuff correctly in
)the documentation.
)

Marc, I compiled it and what you have done from a Doc point of view is fine now 
that I can see it in context.

I see actually that a couple of these paragraphs in general could do with a bit 
of a tidy up both syntactically and grammatically; there is a lot of (IMO) 
unnecessary repetition that could be edited down to be less wordy and more 
instructive-y ;)

I'll take another look at the Doc part only when the patch is approved and 
pushed, so from that point of view your edits for the doc part is:


LGTM!

James

reply via email to

[Prev in Thread] Current Thread [Next in Thread]