lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)


From: pkx166h
Subject: Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)
Date: Sun, 10 Apr 2011 16:06:41 +0000

5th Draft, nothing to really check (apart from Marks 3 spacing edits)
but have removed the ly file now pushed in commit
        524f726a5de0033e68525c65e58430de9b60b7ca

So this is just some admin work so I know that the latest iteration of
the patch is here.


http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode548
Documentation/notation/input.itely:548:
@lilypond[quote,verbatim,noragged-right,staffsize=17,indent=13\mm]
On 2011/04/10 04:11:43, Graham Percival wrote:
I want a general rule for this stuff.  Also, a comment at the top of
the file.

Not Done Yet. I've just removed the ly file (pushed in an earlier commit
as your suggestion) and made Mark's minor spacing adjustments. That way
I know where I am on this patch and know that the latest iteration of
all these changes are here.

I'll work on the comment patch before making any more additions to this
one.

http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode670
Documentation/notation/input.itely:670: fields at opposite ends of the
same line.To force titles to start on a
On 2011/04/09 21:34:27, Mark Polesky wrote:
Use 2 spaces between sentences.

Done.

http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode689
Documentation/notation/input.itely:689: the top and bottom of pages,
separate from the main text of a book. They
On 2011/04/09 21:34:27, Mark Polesky wrote:
Use 2 spaces between sentences.

Done.

http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode701
Documentation/notation/input.itely:701: defined in
@file{ly/titling-init.ly}. By default:
On 2011/04/09 21:34:27, Mark Polesky wrote:
Use 2 spaces between sentences.

Done.

http://codereview.appspot.com/4124056/diff/18001/ly/titling-init.ly
File ly/titling-init.ly (right):

http://codereview.appspot.com/4124056/diff/18001/ly/titling-init.ly#newcode1
ly/titling-init.ly:1: \version "2.12.0"
On 2011/04/10 04:11:43, Graham Percival wrote:
you know, it occurs to me that we could have pushed the patch for this
file ages
ago.

Want to do this now?  Make a new patch, including only this file, and
give it
the commit message "Add clarifications to ly/titleing-init.ly", and
then push.

Done. As 524f726a5de0033e68525c65e58430de9b60b7ca

http://codereview.appspot.com/4124056/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]