|
From: | dak |
Subject: | Re: Filter special characters from PS output. Fix 1605 (issue4382052) |
Date: | Tue, 12 Apr 2011 07:50:45 +0000 |
http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm#newcode412 scm/framework-ps.scm:412: (markup->string val) illegals))))) Apart from creating a new char set on every round, this seems far too adhoc to me. I think one should define a function ps-quote for quoting PostScript strings (a similar function will be useful for every other framework) and make sure that every user-defined string is passed through it before reaching PostScript. http://codereview.appspot.com/4382052/
[Prev in Thread] | Current Thread | [Next in Thread] |