lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allows glissandi between chords (issue4442082)


From: n . puttock
Subject: Re: Allows glissandi between chords (issue4442082)
Date: Thu, 28 Apr 2011 13:47:21 +0000


http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly
File input/regression/glissando-chord.ly (right):

http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly#newcode4
input/regression/glissando-chord.ly:4: texidoc = "LilyPond typesets
glissandi between chords."
This should be two separate tests: one for the basic functionality and
another testing 'glissando-index.

http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc
File lily/glissando-engraver.cc (right):

http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc#newcode51
lily/glissando-engraver.cc:51: SCM map;
Unless you need to preserve the value of glissandoMap between timesteps,
this is redundant.

http://codereview.appspot.com/4442082/diff/3001/lily/glissando-engraver.cc#newcode85
lily/glissando-engraver.cc:85: map = get_property ("glissandoMap");
SCM map = get_property ("glissandoMap");

(see note above)

http://codereview.appspot.com/4442082/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]