|
From: | tdanielsmusic |
Subject: | Re: Bugfix for issue 1630 (issue4490045) |
Date: | Sun, 08 May 2011 08:57:17 +0000 |
LGTM, except for non-standard indentation which should be corrected, although I've tested it only on the examples in the regression tests. Trevor http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right): http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc#newcode92 lily/completion-note-heads-engraver.cc:92: is_first_ = false; indent http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode126 lily/tie-engraver.cc:126: { indent http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode128 lily/tie-engraver.cc:128: { indent http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode297 lily/tie-engraver.cc:297: event_processed = true; indent http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode341 lily/tie-engraver.cc:341: event_ = 0; indent http://codereview.appspot.com/4490045/
[Prev in Thread] | Current Thread | [Next in Thread] |