[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix calculation of vertical offset when 'staff-padding is set (issue

From: Janek Warchoł
Subject: Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)
Date: Tue, 10 May 2011 07:11:20 +0200

2011/5/8 Trevor Daniels <address@hidden>

address@hidden wrote Sunday, May 08, 2011 7:17 AM
Style nitpick.
lily/ bool include_staff =
I see quite a lot of whitespace diffs here and there. IIRC we care about
them, so please fix :)

If you look more carefully you'll see these changes
are actually correcting whitespace errors in the
original code.

Ooops! Sorry :)
I remember that someone once told me that such canges should be done separately from the actual coding stuff - that's why i thought your changes were accidental (i didn't examine them closely indeed).
Honestly i'm not sure if this policy of separating style fixes and coding is good. Surely it's better to have these separated, but this requires additional time and work. I found this a little discouraging - style fixes like that are best done 'by the way'.
 But thanks for taking the trouble
to review my fix :)

I thought it's worth a try since we have too few reviewers. Too bad that i didn't say anything useful :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]