[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fattens the 256 first braces. (issue4518052)
From: |
Carl . D . Sorensen |
Subject: |
Fattens the 256 first braces. (issue4518052) |
Date: |
Tue, 10 May 2011 19:51:20 +0000 |
LGTM, with a small nitpick.
I like the new braces better.
Carl
http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf#newcode148
mf/feta-braces.mf:148: fatten_factor := 1.5;
I think that good practice would have you do a save when you define a
new variable, so you won't override it if it's defined elsewhere in the
file. Using save creates a local variable.
http://codereview.appspot.com/4518052/
- Fattens the 256 first braces. (issue4518052),
Carl . D . Sorensen <=
- Re: Fattens the 256 first braces. (issue4518052), bordage . bertrand, 2011/05/10
- Re: Fattens the 256 first braces. (issue4518052), tdanielsmusic, 2011/05/10
- Re: Fattens the 256 first braces. (issue4518052), bordage . bertrand, 2011/05/10
- Re: Fattens the 256 first braces. (issue4518052), dak, 2011/05/11
- Re: Fattens the 256 first braces. (issue4518052), bordage . bertrand, 2011/05/11
- Re: Fattens the 256 first braces. (issue4518052), dak, 2011/05/11
- Re: Fattens the 256 first braces. (issue4518052), bordage . bertrand, 2011/05/11
- Re: Fattens the 256 first braces. (issue4518052), dak, 2011/05/11