[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

From: k-ohara5a5a
Subject: Re: MIDI: intelligently combine overlapping notes. (issue4520050)
Date: Wed, 11 May 2011 23:12:10 +0000

Reviewers: md5i,

This looks good overall.
I will test out my own suggestions, because if we can make a smaller
change, it will be easier to follow through this complicated stretch of
history in the MIDI-output code.
File flower/include/pqueue.hh (right):
flower/include/pqueue.hh:121: vsize next = i / 2;
On 2011/05/11 13:41:04, md5i wrote:
This should really be tgt / 2, for consistency.

flower/include/pqueue.hh:110: void del (vsize i)
Rather than change the 'flower' library to support deletion from the
heap, I suggest we continue to use the ignore_ flag on items we would
The formerly-used "lazy deletion" technique seems appropriate for the
note-of queue, because deletions are rare.
File lily/ (right):
lily/ if (now_ticks == stop_note_queue[i].val.first
The use of the .first field to cache the note-on-time was difficult for
me to understand.

I suggest following pointers as was done to find now_ticks:
int queued_ticks =
 stop_note_queue[i].val.second->audio_->audio_column_->ticks ()

MIDI: intelligently combine overlapping notes.

Fix issue 1647
A patch from Micheal Duggan

Please review this at

Affected files:
  M flower/include/pqueue.hh
  A input/regression/
  M lily/
  M lily/include/audio-staff.hh
  M lily/include/midi-walker.hh
  M lily/
  M lily/
  M scm/define-context-properties.scm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]