Re: Spacing with empty contexts; issue 1669 (issue4515158)

[joeneeman]

On 2011/06/09 02:55:54, Keith wrote:

http://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc
> File lily/align-interface.cc (right):


http://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc#newcode222
> lily/align-interface.cc:222: dy = max (dy, min_distance);
> On 2011/06/07 04:48:01, joeneeman wrote:
> > If pure is true, there may be some staves that are going to be
removed.
> However,
> > these staves won't be removed until after line-breaking.

> ... and, as you say, these staves are not yet removed when
Y-extent-estimates
> for the page breaker are calculated, so this patch messes up the page
breaker.

> If the page breaker depends on empty, but living, staves disappearing
for
> vertical spacing purposes, then maybe empty staves should be treated
that way
> consistently.

Or maybe we should just be checking for hara-kiri instead of checking
whether the extent is empty... I'll try putting together a patch for
this, since it would be less confusing than the current situation.

> The obvious alternative would be to have the empty staves decide
whether to
> suicide before page breaking, but my suspicion is that is awkward, or
it would
> have been done that way at first.

Yes: we don't know whether a staff is empty until after line breaking.


http://codereview.appspot.com/4515158/