Re: shortened flags: choosing appropriate flag (issue4410049)

[lemniskata . bernoullego]

Ian,

thanks for review!


http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly
File input/regression/shortened-flags-cues.ly (right):

http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly#newcode6
input/regression/shortened-flags-cues.ly:6: }
On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
> Spelling nitpick:
> chosing => choosing

Done.

http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly#newcode11
input/regression/shortened-flags-cues.ly:11: \new CueVoice {
On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
> Use four-space indents in this file rather then eight-space ones.

Done.

http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc
File lily/stem.cc (right):

http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode757
lily/stem.cc:757: when a flagged stem has manually overriden length, the
flag should be
On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
> Nitpick:
> overriden => overridden

Done.

http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode790
lily/stem.cc:790: else
On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
> // (flag_style is not blank)
> It's been a long time since the if() and there was lots of involved
stuff in the
> then {} clause.

Done.

http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode792
lily/stem.cc:792:
On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
> /*
>     Look up the font character allowing for the variant stem length
> */

I don't get it...

> You've done a lot of heavy lifting to get here, this is the  fix;

Thanks :)

> shout about it for the benefit of maintainers.

I'm shouting, but maybe my voice is too soft :)

http://codereview.appspot.com/4410049/