[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shortened flags: choosing appropriate flag (issue4410049)
From: |
Ian Hulin |
Subject: |
Re: shortened flags: choosing appropriate flag (issue4410049) |
Date: |
Fri, 10 Jun 2011 10:04:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b3pre Thunderbird/3.1.9 |
On 10/06/11 09:30, address@hidden wrote:
> Ian,
>
> thanks for review!
<snip>
> http://codereview.appspot.com/4410049/diff/16001/lily/stem.cc#newcode792
> lily/stem.cc:792:
> On 2011/06/09 04:55:10, Ian Hulin (gmail) wrote:
>> /*
>> Look up the font character allowing for the variant stem length
>> */
>
> I don't get it...
>
That block comment is what I understood the next statement to be doing ,
and it's the fix in that routine.
If I've understood it wrong, change the comment words, and it shows the
need for a comment!
Cheers,
Ian
>> You've done a lot of heavy lifting to get here, this is the fix;
>
> Thanks :)
>
>> shout about it for the benefit of maintainers.
>
> I'm shouting, but maybe my voice is too soft :)
>
> http://codereview.appspot.com/4410049/