Re: Current state of automatic footnotes. (issue4580041)

[n . puttock]

Hi Mike,

I'll take a closer look at this at the weekend.

Cheers,
Neil


http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly
File input/regression/footnote-auto-numbering-page-reset.ly (right):

http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly#newcode3
input/regression/footnote-auto-numbering-page-reset.ly:3: texidoc =
"Lilypond does footnotes."
needs a more descriptive texidoc (same applies to other tests)

http://codereview.appspot.com/4580041/diff/10001/lily/balloon.cc
File lily/balloon.cc (right):

http://codereview.appspot.com/4580041/diff/10001/lily/balloon.cc#newcode136
lily/balloon.cc:136: "annotation-whiteout "
needs adding to scm/define-grob-properties.scm

http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly#newcode364
ly/music-functions-init.ly:364: \footnoteGrob $grob-name $offset \markup
{ "" } $footnote
I haven't tested this, but could you use \markup \null instead?

http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly#newcode392
ly/music-functions-init.ly:392: 'text (markup "")
'text (make-null-markup) ?

http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm
File scm/lily-library.scm (right):

http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm#newcode749
scm/lily-library.scm:749: (define-public (random-string pool n)
remove (since you're now using gensym)

http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm#newcode763
scm/lily-library.scm:763: (define-public (random-lowercase-string n)
remove

http://codereview.appspot.com/4580041/