[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067)
From: |
reinhold . kainhofer |
Subject: |
Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067) |
Date: |
Mon, 04 Jul 2011 12:17:46 +0000 |
Reviewers: J_lowe,
Message:
On 2011/07/04 00:18:07, J_lowe wrote:
Hello, I get an error when I try to make:
That's fixed now.
Cheers,
Reinhold
Description:
Fix issue 75: Allow multiple concurrent slurs
Rewrite the Slur_engraver and the Phrasing_slur_engraver to support
multiple concurrent slurs. The default lilypond syntax using parentheses
still supports only one slur at a time, but by adding a slur-id property
to the (Phrasing)SlurEvent music expression, one can create multiple
concurrent slurs, each with a different slur-id.
This finally allows appoggiaturas and acciaccaturas (which both create a
slur from the grace note the the next note) to be placed inside a slur.
Please review this at http://codereview.appspot.com/4643067/
Affected files:
A input/regression/phrasing-slur-multiple.ly
A input/regression/slur-grace.ly
A input/regression/slur-multiple.ly
M lily/phrasing-slur-engraver.cc
M lily/slur-engraver.cc
M lily/slur.cc
M ly/grace-init.ly
M scm/define-grob-properties.scm
M scm/define-grobs.scm
M scm/define-music-properties.scm
M scm/define-music-types.scm
- Fix issue 75: Allow multiple concurrent slurs (issue4643067), pkx166h, 2011/07/03
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067),
reinhold . kainhofer <=
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067), pkx166h, 2011/07/04
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067), Carl . D . Sorensen, 2011/07/05
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067), reinhold . kainhofer, 2011/07/06
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067), n . puttock, 2011/07/07
- Re: Fix issue 75: Allow multiple concurrent slurs (issue4643067), reinhold . kainhofer, 2011/07/09