Re: Does type checking for all context property sets. (issue4654090)

[Neil Puttock]

On 7 July 2011 12:02,  <address@hidden> wrote:
>
> http://codereview.appspot.com/4654090/diff/1/lily/context.cc
> File lily/context.cc (right):
>
> http://codereview.appspot.com/4654090/diff/1/lily/context.cc#newcode496
> lily/context.cc:496: properties_dict ()->set (sym, val);
> else if (do_internal_type_checking_global) {
>  assert(...);
> }
>
> Otherwise do_internaltype_checking_global won't give any indication that
> something was wrong!

I agree, though the assert should come first otherwise
type_check_assignment () gets called twice.

Cheers,
Neil