lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (is


From: bordage . bertrand
Subject: Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)
Date: Thu, 28 Jul 2011 12:24:10 +0000


http://codereview.appspot.com/4536068/diff/37002/lily/multi-measure-rest.cc#newcode241
lily/multi-measure-rest.cc:241: length = (2 << -i) / 2;
The division by 2 changes the result.  Not that I understand too well
what it is
supposed to be doing.

To be honest, I never understood well how this bitset operator works.
What I see is that "2 << -i" gives the same result than "2^(-i+1)".
I should have write "2 << (-i + 1)" instead of "/2"...

Besides this, I would like to remove these ugly "if"s I added yesterday,
but I don't see a better human-readable solution.

Bertrand

http://codereview.appspot.com/4536068/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]