[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (is
benko . pal
Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)
Mon, 01 Aug 2011 11:31:42 +0000
(I'm not a grand-master, :( )
good that you caught the problem with hole in usable-duration-logs, but,
I think, that makes more comment necessary, see below.
all reviewers: is there a convention about using assertions in C++ code?
File lily/multi-measure-rest.cc (right):
lily/multi-measure-rest.cc:255: find the longest usable rest fitting
fitting into measure_count
lily/multi-measure-rest.cc:257: length is its duration (in mdl units)
append to the comment something like
note: if length were zero on exit, the while-loop wouldn't
but this shouldn't happen since mdl is known to be in
and perhaps (what is LP convention?) add an
assert(length > 0);
after the for-loop.
- Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068),
benko . pal <=