Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

[k-ohara5a5a]

I like this approach.


http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):

http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc#newcode102
lily/slur-configuration.cc:102: close_to_edge = close_to_edge || -d *
(p[X_AXIS] - curve_xext[d]) < close_to_edge_length;
This is quite obfuscated.  I am too old to remember details like whether
LEFT<0 in Lilypond.

close_to_edge =  p[X_AXIS] < curve_xext[LEFT]  + c_t_e_l
              || p[X_AXIS] > curve_xext[RIGHT] - c_t_e_l;

I think you are right to have the ignore region be length in
staff-spaces, rather than a fraction of the length of the slur.  Did you
try both ways?

http://codereview.appspot.com/4810072/