lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)


From: PhilEHolmes
Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
Date: Sat, 06 Aug 2011 14:57:14 +0000

Again - not too familiar with the codereview tool, so I hope this makes
sense.  New patch set soon.


http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25
input/regression/mozart-hrn-3.ly:25: \fill-line { "This music is part of
the Mutopia project,"
On 2011/08/02 19:59:39, Neil Puttock wrote:

Can't see a missing line.  I was trying to recreate the old
regtest, but with better syntax, so wasn't adding lines
where they didn't exist.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode28
input/regression/mozart-hrn-3.ly:28: \fill-line { #(ly:export
(string-append "It has been typeset and placed in the public "
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode29
input/regression/mozart-hrn-3.ly:29: "domain by "  maintainer  "."))
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode31
input/regression/mozart-hrn-3.ly:31: \fill-line { #(ly:export
(string-append "Unrestricted modification and redistribution"
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode32
input/regression/mozart-hrn-3.ly:32: " is permitted and
encouraged---copy this music"
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode33
input/regression/mozart-hrn-3.ly:33: " and share it!"))
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode53
input/regression/mozart-hrn-3.ly:53: system-system-spacing
#'basic-distance = 10 \mm
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode54
input/regression/mozart-hrn-3.ly:54: score-system-spacing
#'basic-distance = 20 \mm
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode61
input/regression/mozart-hrn-3.ly:61: \header { piece = "Allegro" opus =
"" }
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode73
input/regression/mozart-hrn-3.ly:73: \header { piece = "Romanze" opus =
"" }
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode82
input/regression/mozart-hrn-3.ly:82: \layout {}
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode88
input/regression/mozart-hrn-3.ly:88: \header { piece = "Rondo" opus = ""
}
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily
File input/regression/mozart-hrn3-defs.ily (right):

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode16
input/regression/mozart-hrn3-defs.ily:16: \override MultiMeasureRest
#'padding = #0.5
On 2011/08/02 19:59:39, Neil Puttock wrote:

If it doesn't do anything, I'll just take it out.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode22
input/regression/mozart-hrn3-defs.ily:22: \override Beam #'thickness =
#0.6
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode23
input/regression/mozart-hrn3-defs.ily:23: \override Beam
#'space-function = #(lambda (beam mult) 0.8)
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode27
input/regression/mozart-hrn3-defs.ily:27: \override VerticalAxisGroup
#'minimum-Y-extent = #'(-2.5 . 3.5)
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode32
input/regression/mozart-hrn3-defs.ily:32: indent = 10. \mm
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-defs.ily#newcode33
input/regression/mozart-hrn3-defs.ily:33: line-width = 189. \mm
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-rondo.ily
File input/regression/mozart-hrn3-rondo.ily (right):

http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn3-rondo.ily#newcode23
input/regression/mozart-hrn3-rondo.ily:23: rondo =    \relative c' {
On 2011/08/02 19:59:39, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4811066/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]