[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Version specific code

From: Graham Percival
Subject: Re: Version specific code
Date: Mon, 8 Aug 2011 14:31:41 -0700
User-agent: Mutt/1.5.20 (2009-06-14)

On Mon, Aug 08, 2011 at 04:48:46PM +0100, Phil Holmes wrote:
> In, we have the following:
>            if (line.find('2.12') >= 0):
>                line = line.replace('a href=', 'a
> onClick=\"javascript:urchinTracker(\'/download/v2.12\');\" href=')
>            elif (line.find('2.13') >= 0):
>                line = line.replace('a href=', 'a
> onClick=\"javascript:urchinTracker(\'/download/v2.13\');\" href=')
> This (I think) means we're currently not using the Google analytics
> to track downloads.

That sounds like a reasonable investigation.  Next step: does the
html source contain any urchinTracker?  If not, then we're
definitely not using the Google analytics!

Once this bug is confirmed, please either add it to the tracker,
or fix that part (test it the same way you investigated whether
it's actually there or not, in the html source).  Or both, I
suppose, but this doesn't look like a long job so we might as well
fix it and push directly.

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]